Feature #802

Plugins: settings.createComboBox like in showtime settings

Added by andreus sebes about 11 years ago. Updated about 11 years ago.

Status:FixedStart date:12/07/2011
Priority:NormalDue date:
Assignee:Andreas Smas% Done:

100%

Category:Plugins
Target version:3.4

Description

In the plugin, make possible to create a setting from combobox like showtime as in settings (for example for the charset)

Associated revisions

Revision de54b8db
Added by Andreas Smas about 11 years ago

js: Add createMultiOpt() to the settings object and fix various race conditions.

In addition make the settings object properly resource tracked instead
of relying on the spidermonkey GC to reap the objects.

Fixes #802

Revision e52be6a8
Added by Andreas Smas about 11 years ago

Fix problems with multiopt in javascript

Fixes #802 (again)

History

#1 Updated by Andreas Smas about 11 years ago

  • Status changed from New to Accepted
  • Target version changed from 3.4 to 33

+1

#2 Updated by Andreas Smas about 11 years ago

  • Status changed from Accepted to Fixed
  • % Done changed from 0 to 100

#3 Updated by Andreas Smas about 11 years ago

  • Target version changed from 33 to 3.4

#4 Updated by andreus sebes about 11 years ago

Hi Andreas!

It's working good. Just one problem. The Up and Down arrows don't appear in my showtime on PS3. Bad Path?

#5 Updated by andreus sebes about 11 years ago

Another problem detected.
If i install the plugin from sratch (cleaning old settings) showtime will not read the combobox setting and gives an error

#6 Updated by Andreas Smas about 11 years ago

Please don't reuse bugs :(

#7 Updated by andreus sebes about 11 years ago

Andreas, i'm sorry but this two problems are related so i thought i had to put it here.
Since i can't reopen it i wrote here.

But, of course, if you want that i always create new ones, even if is about the same question i create.

#8 Updated by Fábio Ferreira about 11 years ago

I confirm this bug, but it only requires a simple edit of a setting in plugin's settings as workaround, but is not a good solution for the ending user.

#9 Updated by Andreas Smas about 11 years ago

Ok, so .. seems there are a lot of broken stuff in the multiopt things.

But it's certainly problems there yes. I'll try to fix them

Also available in: Atom PDF