Bug #3029
Menu bar is over subtitles if you change default position
Status: | Fixed | Start date: | 04/01/2016 | |
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | % Done: | 100% | ||
Category: | Video playback | |||
Target version: | 5.2 | |||
Found in version: | 5.0 | Platform: | PS3 |
Description
When the menu bar with icons is shown, the subtitles are moved up, so both are shown but not overlapping.
If you change the default subtitles position to a lower one, the menu bar is shown over the subtitles, because they are not moved up enough, just the fixed and default amount.
Move always the subtitles above the menu bar instead of a fixed amount.
Associated revisions
video: Fix subtitle displacement in combindation with OSD
Fixes #3029
History
#1
Updated by Rob Koni about 5 years ago
Maybe attach a screenshot so we know what is happening. Movian supports uploading screenshots via the webui now
#2
Updated by . . about 5 years ago
- File Movian_1.png added
- File Movian.png added
#3
Updated by Andreas Smas about 5 years ago
- Target version set to 5.2
#4
Updated by Andreas Smas about 5 years ago
- Status changed from New to Fixed
- % Done changed from 0 to 100
Applied in changeset git|ee69880db3620610940d57a37663f3da54768d61.
#5
Updated by . . about 5 years ago
I've tested it and it's not fixed. Now the subtitles look in a much a higher position over the OSD with the default vertical setting, but when using a lower vertial setting they still appear over the OSD like in the picture. So now subtitles look bad both times, too high by default and over OSD if it's low.
You have to set the vertical subtitle position just a little above the OSD like before no matter what. Please don't use a fixed amount of vertical displacement. Move the subtitles when needed then back to where they where.
So by default, like it was before this fix, let's say you moved subtitles up 10 pixels. If the user lowers them 100 pixels, you have to detect how much you need to compensate so they look the same when displaying the OSD. Same for -150, -200 etc. It can't be a fixed amount like you tried.
An also take into account the scaling, because the bigger subtitles are, the more vertical space they take. Since OSD is the big new feature in 5.0, you have to be sure buttons can be seen.
Thanks.