Bug #2684

Better error reporting for tracker-less magnet links

Added by Michal Pisarski over 4 years ago. Updated about 4 years ago.

Status:FixedStart date:06/12/2015
Priority:NormalDue date:
Assignee:Andreas Smas% Done:

100%

Category:General
Target version:5.0
Found in version:4.9.46.g5134a.dirty Platform:Linux

Description

As in file bittorrent/bt_backend.c there is a piece of code that allows opening torrents and magnet links.

static int
bt_open(prop_t *page, const char *url, int sync)
{
  const char *u;

  if((u = mystrbegins(url, "torrent:video:")) != NULL) {
    return torrent_movie_open(page, u, sync);
  } else if((u = mystrbegins(url, "torrent:browse:")) != NULL) {
    return torrent_browse_open(page, u, sync);
  } else if((u = mystrbegins(url, "magnet:")) != NULL) {
    return torrent_browse_open(page, url, sync);
  }

  return 0;
}

Torrents work when used as "torrent:browse:http://something.com/my_torrent.torrent" or "torrent:video:http://something.com/my_torrent.torrent" but magnet link "magnet:?xt=urn:btih:F49F64DB758A7E854C57DC60D7CC43061A2A02DA" does not work.
The "loading wheel" works for some time but then disappears and blank view is shown (with showtime background).


Related issues

Duplicated by Feature #2470: Add DHT support to bittorrent client Fixed 01/07/2015

Associated revisions

Revision 42411ebc
Added by Andreas Smas about 4 years ago

Fail when trying to open tracker-less torrents

Fixes #2684

Change included in version 4.99.543

History

#1 Updated by Andreas Smas over 4 years ago

  • Duplicated by Feature #2470: Add DHT support to bittorrent client added

#2 Updated by Andreas Smas over 4 years ago

Yeah, the problem here is that there are no trackers in the magnet-link and Movian does not yet support DHT so it can't find any peers.

The error reporting could be better though...

#3 Updated by Andreas Smas about 4 years ago

  • Subject changed from Magnet links to Better error reporting for tracker-less magnet links
  • Target version set to 5.0

#4 Updated by Andreas Smas about 4 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Also available in: Atom PDF