Bug #2512

canonicalUrl supplied via videoparams wont work in duktape mode

Added by Leonid Protasov almost 6 years ago. Updated almost 6 years ago.

Status:FixedStart date:01/23/2015
Priority:HighDue date:
Assignee:Andreas Smas% Done:

100%

Category:Ecmascript & Duktape
Target version:4.10
Found in version:4.9.93 Platform:Linux

Description

Try baskino plugin for example. Play something and you will see that pos is not shown at the item duration. Works properly on js.

Associated revisions

Revision ba04c9c5
Added by Andreas Smas almost 6 years ago

ecmascript/page.js: Fix typo when parsing videoparams in page.appendItem

Fixes #2512

Change included in version 4.9.98

History

#1 Updated by Andreas Smas almost 6 years ago

  • Status changed from New to Need feedback

I browse

baskino:index:http%3A//baskino.com/films/boeviki/10739-dzhon-uik.html

The first item addes has URL

"baskino:moonwalk:http%3A//moonwalk.cc/video/fb9a7072a9bc7d61/iframe:%u0414%u0436%u043E%u043D%20%u0423%u0438%u043A%20%7C%20John%20Wick" 

So no canonicalUrl present

But when playing, it plays:

vp [DEBUG]: Playing 'videoparams:{"title":"Джон Уик | John Wick","imdbid":"tt2911666","sources":[{"url":"hls:http://moonwalk.cc/video/57bb9c3534e7aa77/index.m3u8"}]}', primary

So the metadata gets bound to:

hls:http://moonwalk.cc/video/57bb9c3534e7aa77/index.m3u8

Thus, there is a mismatch for the kvstore..

As can be seen when turning on kvstore debug:

Keys are read from

kvstore         [DEBUG]: GET DB url=baskino:indexURL:http%3A//baskino.com/actors/%25CA%25E8%25E0%25ED%25F3+%25D0%25E8%25E2%25E7/ key=restartposition domain=1 value=UNSET

after exiting video keys are written to:

kvstore         [DEBUG]: SET DB url=hls:http://moonwalk.cc/video/57bb9c3534e7aa77/index.m3u8 key=restartposition domain=1 value=216734 rc=0

I think this is a bug in the plugin somehow.

#2 Updated by Leonid Protasov almost 6 years ago

I'm sorry, that's true the bug is in plugin. But if you try multifile videos in liveleak plugin - the bug is there.
Try:

liveleak:play:http%3A//www.liveleak.com/view%3Fi%3D5ee_1421732802:3%20Ton%20Power%20Hammer%20-%20Would%20You%20Work%20Here%3F

#3 Updated by Andreas Smas almost 6 years ago

  • Status changed from Need feedback to Fixed
  • % Done changed from 0 to 100

Also available in: Atom PDF