Bug #2465

opensubtitles wont work in duktape mode

Added by Leonid Protasov almost 6 years ago. Updated almost 6 years ago.

Status:InvalidStart date:01/06/2015
Priority:NormalDue date:
Assignee:Andreas Smas% Done:

0%

Category:Subtitles
Target version:4.10
Found in version:4.9.32 Platform:RPi

History

#1 Updated by Andreas Smas almost 6 years ago

  • Priority changed from High to Normal

Works fine for me...

Can you turn on HTTP debug and see what's going on?

#2 Updated by Leonid Protasov almost 6 years ago

Andreas Öman wrote:

Works fine for me...

Can you turn on HTTP debug and see what's going on?

That was just 503 (internal server error). But just to get rid of that error in the log - plugin could do like:

try {
 var r = showtime.xmlrpc(APIURL, "LogIn", '', '', 'en',
                  'Showtime ' + showtime.currentVersionString);
} catch(err) {
    showtime.trace(err);
}

#3 Updated by Andreas Smas almost 6 years ago

  • Status changed from New to Invalid

But then the 'r' variable will be incorrect? I don't see how that helps at all.

It's better to error out when there is an error.

#4 Updated by Leonid Protasov almost 6 years ago

Andreas Öman wrote:

But then the 'r' variable will be incorrect? I don't see how that helps at all.

It's better to error out when there is an error.

This way it will be the best:

try {
var r = showtime.xmlrpc(APIURL, "LogIn", '', '', 'en',
'Showtime ' + showtime.currentVersionString);
} catch(err) {
token = null;
trace('Login failed: ' + err);
return;
}

Also available in: Atom PDF