Bug #2385

Showtime never gives up on a HLS segment it is unable to open

Added by Jordan Scango almost 6 years ago. Updated almost 6 years ago.

Status:FixedStart date:11/22/2014
Priority:NormalDue date:
Assignee:Andreas Smas% Done:

100%

Category:HLS
Target version:4.8
Found in version:4.7.486 Platform:PS3

Description

This occurs rarely, but reliably watching Twitch.tv streams. From reading the log, it seems the segment 404's, but showtime never stops trying to open it, to the point of degrading performance and requiring a restart. At the very least it should give up after some number of tries, but ideally it would reload the stream too.

I'm reporting in 4.7.486, but I've noticed it in older builds too. Example log attached.

showtime-0.log - Showtime goes crazy and stuff (110 KB) Jordan Scango, 11/22/2014 10:57 PM

Associated revisions

Revision 6962bc5f
Added by Andreas Smas almost 6 years ago

hls: Improve handling of missing segments

Fixes #2385

Change included in version 4.7.513

History

#1 Updated by Leonid Protasov almost 6 years ago

  • Target version set to 4.8

#2 Updated by Leonid Protasov almost 6 years ago

  • Related to Bug #2247: UI elements affect aspect ratio when HLS player switches between variants (RPi) added

#3 Updated by Leonid Protasov almost 6 years ago

Jordan, can you please update to the latest Bleeding Edge and test again?

#4 Updated by Jordan Scango almost 6 years ago

Have been running it for for a few hours, so far so good. I'm not sure how I can force a 404 to really know though, just causing a network interruption isn't enough apparently.

#5 Updated by Andreas Smas almost 6 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

#6 Updated by Andreas Smas almost 6 years ago

I've modified the segment open code to periodically fail to open a segment (as a test modification of course :-)

During this I've tested and modified the code so it now alternate among all the different bitrates trying to stay on the one with the least amount of errors.

#7 Updated by Andreas Smas almost 6 years ago

  • Related to deleted (Bug #2247: UI elements affect aspect ratio when HLS player switches between variants (RPi))

Also available in: Atom PDF