Bug #2351
page.metadata props are not accessible from page.options.createInt/createBool scope at some conditions (duktape)
| Status: | Fixed | Start date: | 11/08/2014 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Andreas Smas | % Done: | 100% | |
| Category: | API | |||
| Target version: | 4.8 | |||
| Found in version: | Latest BE | Platform: | Linux |
Description
To reproduce:
1. In icecast plugin add something to favorites via item menu
2. Go into favorites and you get:
icecast [ERROR]: TypeError (unexpected type) at (null):0
icecast [ERROR]: STACK DUMP: TypeError: unexpected type
duk_api_stack.c:1266
Proxy native strict construct preventsyield
makeProp showtime/prop:63
anon showtime/prop:28 preventsyield
anon showtime/page:100 preventsyield
anon file:///root/showtime-plugins/icecast/icecast.js:30
anon showtime/settings:133 preventsyield
apply native strict preventsyield
anon showtime/prop:109 preventsyield
icecast [ERROR]: TypeError (unexpected type) at (null):0
icecast [ERROR]: STACK DUMP: TypeError: unexpected type
duk_api_stack.c:1266
Proxy native strict construct preventsyield
makeProp showtime/prop:63
anon showtime/prop:28 preventsyield
anon showtime/page:100 preventsyield
anon file:///root/showtime-plugins/icecast/icecast.js:33
anon showtime/settings:133 preventsyield
apply native strict preventsyield
anon showtime/prop:109 preventsyield
icecast [ERROR]: TypeError (unexpected type) at (null):0
icecast [ERROR]: STACK DUMP: TypeError: unexpected type
duk_api_stack.c:1266
Proxy native strict construct preventsyield
makeProp showtime/prop:63
anon showtime/prop:28 preventsyield
anon showtime/page:100 preventsyield
anon file:///root/showtime-plugins/icecast/icecast.js:36
anon showtime/settings:71 preventsyield
apply native strict preventsyield
anon showtime/prop:109 preventsyield
The most interesting is that if you just add favorites, close showtime, reopen it and go directly to the favorites - you see no errors.
Related issues
Associated revisions
ecmascript/page: Fix broken use of this. in some callbacks
Fixes #2351
History
#1
Updated by Leonid Protasov over 6 years ago
- Related to Bug #2333: duktape can't handle page.metadata.title in title parameter of appendItem and appendPassiveItem (in spidermonkey it's fine) added
#2
Updated by Andreas Smas over 6 years ago
- Status changed from New to Fixed
- % Done changed from 0 to 100
Applied in changeset git|3da23033e126526810fa5d1ed33d203cb4f3f7b9.