Bug #2206

Tv channel not sorting by number

Added by Aleksandr Faronov almost 7 years ago. Updated over 6 years ago.

Status:FixedStart date:07/07/2014
Priority:NormalDue date:
Assignee:Andreas Smas% Done:

100%

Category:HTSP client
Target version:4.8
Found in version:4.2 Platform:RPi

Description

If i set in tvheadend channel numbers order in showtime i have different order.
This bug on all platform.

Associated revisions

Revision 8b70a413
Added by Andreas Smas over 6 years ago

htsp: Sort TV channels based on channelNumber from Tvheadend

Fixes #2206

Change included in version 4.7.181

Revision d9e157c8
Added by Andreas Smas over 6 years ago

htsp: Sort channels in datamodel based on channelNumber

Fixes #2206 (for real)

Change included in version 4.7.183

History

#1 Updated by John Törnblom almost 7 years ago

I made a quick hack that works good enough for me:

diff --git a/glwskins/default/pages/tvchannels.view b/glwskins/default/pages/tvchannels.view
index ec827b2..50b61c5 100644
--- a/glwskins/default/pages/tvchannels.view
+++ b/glwskins/default/pages/tvchannels.view
@@ -37,7 +37,8 @@ widget(container_y, {

        &self.focused = focusedChild();

-       cloner($page.model.nodes, container_z, {
+       cloner(propSorter($page.model.nodes,
+                         sort, "node.metadata.channelNumber", false, false), container_z, {
          autoRefocusable: true;
          focusable: true;
          width: $ui.size * 12;

#2 Updated by Aleksandr Faronov over 6 years ago

Good hack
but i can't found glwskins on RPI build
it compiled inside showtime , or i miss something :)

And how about zapping channel , this only one thing that i can't use showtime as regular watch TV :(

#3 Updated by Dreamcat 4 over 6 years ago

The current channel order in showtime is not desirable in any way. I would also like to see this patch merged / added. Please Andreas?

For example, if I create a new tag named "BBC Channels", and assigned them first BBC 1, then BBC 2 etc. That is the order i assigned them to the tag. Then showtime will display in the reverse of that order.

http://i.imgur.com/Umm1Kuc.png

I think that explanation does not matter to this offered patch. Just to know why the previous behaviour is wrong. Sorting by channel number is so much better. You should take this patch please.

Maybe later on we may try implementing some kind of multiple-sort field option. However at this time Andreas (who wrote htsp client) isn't active on using showtime for watching TV.

#4 Updated by Andreas Smas over 6 years ago

  • Target version set to 4.8

#5 Updated by Andreas Smas over 6 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

#6 Updated by Dreamcat 4 over 6 years ago

John Törnblom wrote:

I made a quick hack that works good enough for me:

[...]

Tried this and it works for "TV Channels" view mode. But not list view mode…

Perhaps we also need to add something similar in the file "list.view".

https://github.com/andoma/showtime/blob/8b70a4135fbf038b95ab9757f9ead8af20a5b8fd/glwskins/default/pages/list.view

#7 Updated by Dreamcat 4 over 6 years ago

I tested same change in Pull request #170 for list.view also.

https://github.com/andoma/showtime/pull/170

Also available in: Atom PDF