Bug #1871

Codepage is not applied on SUB subtitles

Added by Leonid Protasov almost 7 years ago. Updated almost 7 years ago.

Status:FixedStart date:01/21/2014
Priority:HighDue date:
Assignee:Andreas Smas% Done:

100%

Category:Subtitles
Target version:4.4
Found in version:latest Platform:Linux

Description

I checked different movies with SRT and SUB subtitles at the same time. In the log I see that codepage is selected properly and language is detected ok. If subtitles are in SRT format - it displays ok. But in SUB format - looks like codepage conversion is not applied to the subtitle text.

To reproduce - just open any movie which has srt and sub subtitles in Swedish, Polish etc language on opensubtitles and compare how national symbols display.

All platforms are affected.

Associated revisions

Revision 611fc16b
Added by Andreas Smas almost 7 years ago

Make .sub subtitle parser handle UTF-8 correctly

Fixes #1871

Change included in version 4.3.733

History

#1 Updated by Rural Hunter almost 7 years ago

same with #1740?

#2 Updated by Leonid Protasov almost 7 years ago

No. Subtitle text I talk about are in codepages 1252 and 1250. ST supports them and autodetects properly. But only for SRT. If subtitle is SUB format - codepage is not applied.

#3 Updated by Andreas Smas almost 7 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset git|commit:611fc16b5576c3673c54b417a2e548db09a91082.

Also available in: Atom PDF