Bug #1740

ST doesn't decode Big5 in ASS subtitles

Added by Rural Hunter over 7 years ago. Updated about 7 years ago.

Status:FixedStart date:08/22/2013
Priority:NormalDue date:
Assignee:Andreas Smas% Done:

100%

Category:Subtitles
Target version:4.6
Found in version:All Platform:Linux

Description

Seems now only UTF8 is supported. It would be nice if other file encodings are also supported like SRT subtitles

Boardwalk.Empire.S03E02.720p.BluRay.x264.DTS-WiKi.ass (125 KB) Rural Hunter, 09/08/2013 10:23 AM

Associated revisions

Revision a01086dd
Added by Andreas Smas about 7 years ago

Add support for BIG5 character encoding

Fixes #1740

Change included in version 4.5.7

History

#1 Updated by Andreas Smas over 7 years ago

  • Status changed from New to Need feedback

Can you attach an example?

#3 Updated by Andreas Smas over 7 years ago

Ok, so what is this encoding? Just so I know if I'm doing the right thing or not :-)

#4 Updated by Rural Hunter over 7 years ago

This is in BIG5 file encoding. I don't think it's supported by showtime for now. My point is I don't see anything in code of ASS handling to transfer the encoding to UTF8 as what is done for SRT, if I understand the code correctly.

#5 Updated by Leonid Protasov about 7 years ago

  • Tracker changed from Feature to Bug
  • Subject changed from Support other file encoding for external ASS subtitles to ST doesn't decode Big5 in ASS subtitles
  • Found in version set to All
  • Platform set to Linux

#6 Updated by Rural Hunter about 7 years ago

Actually I just wanted showtime to provide the interface to support other encodings for ASS subtitles, same as it does for SRT subtitiles. BIG5 is just an sample I provided. There are 3 main encodings for Chinese: GB2312, BIG5, GBK(mainly super set of GB2312 and BIG5).
I already implemented GB2312 support for SRT files in my build. If showtime plans to support Chinese encoding, I suggest support GBK/GB18030, not BIG5 or GB2312.

#7 Updated by Leonid Protasov about 7 years ago

  • Target version set to 4.6

#8 Updated by Andreas Smas about 7 years ago

  • Status changed from Need feedback to Fixed
  • % Done changed from 0 to 100

Applied in changeset git|commit:a01086dd172ab91f21bb142242f95feb536f6a35.

Also available in: Atom PDF